Fixes translate(100px, undefinedpx), and transition transform#84
Closed
atotic wants to merge 3 commits intorstacruz:masterfrom
Closed
Fixes translate(100px, undefinedpx), and transition transform#84atotic wants to merge 3 commits intorstacruz:masterfrom
atotic wants to merge 3 commits intorstacruz:masterfrom
Conversation
Contributor
Author
|
Only my 1st commit fixes the problems. The other 2 should not be part of this patch, and were comitted after the pull request. I am not sure how to remove them. |
Owner
|
Hmm—in the first place, |
rstacruz
added a commit
that referenced
this pull request
Dec 13, 2012
…transitioned properties. (atotic, #84)
Owner
|
I've cherry-picked your relevant commit out—it won't show up here as a merge (because it's not), but your fix should be in there scheduled for 1.0.0. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 minor bug fixes:
css('translate' ,100) was setting
-moz-translate(100px, undefinedpx),
instead of
-moz-translate(100px, 0px)
causing css asignment to fail.
Problem was strict equality with null. Added check for undefined fixes the bug.
css('transition', 'transform 0.2s') was setting
-moz-transition transform 0.2s
instead of
-moz-transition MozTransform 0.2s
causing transition not to run at all.
Fix is to use prefixed properties as transition arguments.
Love the library! Thanks.