Syntax for complete callback. Complete should be in second param.#170
Open
hannesjohansson wants to merge 2 commits intorstacruz:masterfrom
Open
Syntax for complete callback. Complete should be in second param.#170hannesjohansson wants to merge 2 commits intorstacruz:masterfrom
hannesjohansson wants to merge 2 commits intorstacruz:masterfrom
Conversation
… the second (the options) parameter
Author
|
This pull request fixes the bug in the test case: But to be compatible with jquery.animate() you should still pass the complete function in the second parameter |
Author
|
This is the same issue as #169 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'as "complete"' test is broken in both IE and Chrome as the complete callback is fired before the animation ends. This is fixed by passing complete as a part of the second parameter object.
This is also how jQuery animate does it, as transition() follows its syntax:
http://api.jquery.com/animate/
Passing a complete callback inside the first object does not work in $.fn.animate:
http://codepen.io/anon/pen/fErzb