Skip to content

Makes code compatible with jsHint #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rstacruz merged 1 commit into from
Dec 15, 2011
Merged

Makes code compatible with jsHint #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions jquery.transit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@
function Transform(str) {
if (typeof str === 'string') this.parse(str);
return this;
};
}

Transform.prototype = {
// ### setFromString()
Expand Down Expand Up @@ -324,7 +324,7 @@
toString: function(use3d) {
var re = [];

for (i in this) {
for (var i in this) {
if ((this.hasOwnProperty(i)) && (i[0] !== '_')) {
if ((use3d) && ((i === 'scale') || (i === 'translate')))
re.push(i + "3d(" + this[i] + ",0)");
Expand All @@ -341,7 +341,7 @@
if (queue === true)
self.queue(fn);
else if (queue)
self.queue(queue, fn)
self.queue(queue, fn);
else
fn();
}
Expand Down Expand Up @@ -381,7 +381,7 @@

// Build the duration/easing/delay attributes for it.
var attribs = '' + toMS(duration) + ' ' + easing;
if (parseInt(delay) > 0)
if (parseInt(delay, 10) > 0)
attribs += ' ' + toMS(delay);

// For more properties, add them this way:
Expand Down Expand Up @@ -464,8 +464,8 @@
}

// Set defaults. (`400` duration, `ease` easing)
if (duration == null) duration = $.fx.speeds._default;
if (easing == null) easing = $.cssEase._default;
if (duration === null) duration = $.fx.speeds._default;
if (easing === null) easing = $.cssEase._default;

duration = toMS(duration);

Expand All @@ -475,7 +475,7 @@
// Compute delay until callback.
// If this becomes 0, don't bother setting the transition property.
var work = $.transit.enabled && support.transition;
var i = work ? (parseInt(duration) + parseInt(delay)) : 0;
var i = work ? (parseInt(duration, 10) + parseInt(delay, 10)) : 0;

// If there's nothing to do...
if (i === 0) {
Expand Down Expand Up @@ -554,12 +554,12 @@

$.cssHooks[prop] = {
get: function(elem) {
var t = $(elem).css('transform') || new Transform;
var t = $(elem).css('transform') || new Transform();
return t.get(prop);
},

set: function(elem, value) {
var t = $(elem).css('transform') || new Transform;
var t = $(elem).css('transform') || new Transform();
t.setFromString(prop, value);

$(elem).css({ transform: t });
Expand All @@ -571,7 +571,7 @@
// Converts a camelcase string to a dasherized string.
// (`marginLeft` => `margin-left`)
function uncamel(str) {
return str.replace(/([A-Z])/g, function(letter) { return '-' + letter.toLowerCase(); })
return str.replace(/([A-Z])/g, function(letter) { return '-' + letter.toLowerCase(); });
}

// ### unit(number, unit)
Expand All @@ -581,11 +581,11 @@
// unit(2, 'px') //=> "2px"
// unit("30deg", 'rad') //=> "30deg"
//
function unit(i, unit) {
function unit(i, units) {
if ((typeof i === "string") && (!i.match(/^[\-0-9\.]+$/)))
return i;
else
return "" + i + unit;
return "" + i + units;
}

// ### toMS(duration)
Expand All @@ -605,4 +605,4 @@

// Export some functions for testable-ness.
$.transit.getTransitionValue = getTransition;
})(jQuery);
})(jQuery);