Skip to content

fixes #76 - compatibility issue with jQuery 1.8#77

Merged
rstacruz merged 0 commit intorstacruz:masterfrom
Datrio:master
Dec 13, 2012
Merged

fixes #76 - compatibility issue with jQuery 1.8#77
rstacruz merged 0 commit intorstacruz:masterfrom
Datrio:master

Conversation

@Datrio
Copy link
Contributor

@Datrio Datrio commented Sep 30, 2012

Fixing the problem with "Uncaught TypeError: Object none has no method 'setFromString'"

@jacobq
Copy link

jacobq commented Oct 10, 2012

I'm confused which version is the "latest" since there seem to be several "0.1.3" versions around. I assumed that rstacruz's repository would be the one to use, but it seems that it doesn't have any jQuery 1.8.x fixes merged in (neither this one nor this older one: cheald@b4684ae#jquery.transit.js ). Am I missing something?

@Datrio
Copy link
Contributor Author

Datrio commented Oct 10, 2012

I don't think rstacruz is further developing the plugin, so there's no "official" fix. You can either use one of the fixed forks (my fork was made 10 days ago) or just fix it yourself, since I think you can see it's terribly easy :)

@jacobq
Copy link

jacobq commented Oct 10, 2012

@Datrio, yeah, that's what we did for now, but of course it looks bad (when using this for a professional project) to have code that says it's one version but which differs from the author's source code bearing the same version number. Anyways, thanks for making the PR.

@Filirom1
Copy link

+1

@ceefour
Copy link

ceefour commented Oct 27, 2012

+1 for this

@ariellephan
Copy link

Awesome! +1

@clemens
Copy link

clemens commented Nov 17, 2012

Works fine for me and also solves issues with Firefox 16 (which uses CSS transforms without a vendor prefix).

@rstacruz rstacruz merged commit d6a8379 into rstacruz:master Dec 13, 2012
@rstacruz
Copy link
Owner

Thank you! Sorry it took so long to merge this in.

@rstacruz rstacruz mentioned this pull request Dec 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants