Closed
Conversation
… is being overshadowed by the this.sort instance-level object. Changing all references for the sort object from sort to sortDictionary to keep the public API consistent, and then moving some sort functionality from renderTableHeader out into its own function that can be called by both the click handler and the prototype.sort function, and fixing issues that popped up there.
|
😎 👍 |
Owner
|
Thanks and landed in version 1.2.0 which will be publicly available in the next few days. |
Owner
|
I have recently published the release candidate (prerelease version including all features) to NPM and NuGet. Would be nice and very appreciated to get your feedback before publishing it. |
Author
|
I can try to take a look sometime this evening if you can tell me where to find it :) |
Owner
|
It is available on the NPM Registry, nuget.org and in the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing sort plugin method, it lives on the Grid.prototype object, and is... being overshadowed by the this.sort instance-level object. Changing all references for the sort object from sort to sortDictionary to keep the public API consistent, and then moving some sort functionality from renderTableHeader out into its own function that can be called by both the click handler and the prototype.sort function, and fixing issues that popped up there.