-
Notifications
You must be signed in to change notification settings - Fork 22
Added attributes to the Config #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 👍
Hi @hamidadelyar ,I realized that there is a problem with {
attributes?(fileName: string): { [name: string]: string }
} |
|
|
Hey @runjuu, I'm not entirely sure what you mean. Do you mean changing the Config in types.ts to this? export interface Config {
filter?(fileName: string): boolean
leaveCSSFile?: boolean
replace?: ReplaceConfig
attributes?(fileName: string): { [name: string]: string }
} I'm not entirely sure what this does, also typescript complains about it. Feel free to make the change :) |
Hi @hamidadelyar , I will merge the PR into |
Hey,
Really appreciate this package, great work!
Made a small tweak to allow attributes for the <style> tag rather than assuming type="text/css"
Let me know what you think!
Thanks,
Hamid