Skip to content

Commit b8ec78a

Browse files
authored
Tests: Skip a scrollbar test in jQuery 3.2
jQuery 3.2 incorrectly handle scrollbars in WebKit/Blink-based browsers. This is fixed in version 3.3, see jquery/jquery#3589. As the data here comes from jQuery directly and the changes to fix it are non-trivial: jquery/jquery#3656, just accept that scrollbar data in this jQuery version is inaccurate. Closes jquerygh-1927 Ref jquery/jquery#3589 Ref jquery/jquery#3656
1 parent 42bcdb9 commit b8ec78a

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

tests/unit/position/core.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,13 @@ QUnit.test( "within", function( assert ) {
640640
}, "flipfit - left top" );
641641
} );
642642

643-
QUnit.test( "with scrollbars", function( assert ) {
643+
// jQuery 3.2 incorrectly handle scrollbars in WebKit/Blink-based browsers.
644+
// This is fixed in version 3.3, see https://github.com/jquery/jquery/issues/3589.
645+
// As the data here comes from jQuery directly and the changes to fix it
646+
// are non-trivial: https://github.com/jquery/jquery/pull/3656, just accept
647+
// that scrollbar data in this jQuery version is inaccurate.
648+
QUnit[ jQuery.fn.jquery.substring( 0, 4 ) === "3.2." ? "skip" : "test" ](
649+
"with scrollbars", function( assert ) {
644650
assert.expect( 4 );
645651

646652
$( "#scrollx" ).css( {

0 commit comments

Comments
 (0)