Tests: Skip a scrollbar test in jQuery 3.2 #1927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jQuery 3.2 incorrectly handle scrollbars in WebKit/Blink-based browsers. This is fixed in version 3.3, see jquery/jquery#3589. As the data here comes from jQuery directly and the changes to fix it are non-trivial: jquery/jquery#3656, just accept that scrollbar data in this jQuery version is inaccurate. Ref jquery/jquery#3589 Ref jquery/jquery#3656
dmethvin
approved these changes
Jul 19, 2020
arschmitz
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jQuery 3.2 incorrectly handle scrollbars in WebKit/Blink-based browsers.
This is fixed in version 3.3, see jquery/jquery#3589.
As the data here comes from jQuery directly and the changes to fix it
are non-trivial: jquery/jquery#3656, just accept
that scrollbar data in this jQuery version is inaccurate.
Ref jquery/jquery#3589
Ref jquery/jquery#3656