Skip to content

Tests: Skip a scrollbar test in jQuery 3.2#1927

Merged
mgol merged 1 commit into
jquery:masterfrom
mgol:tests-scrollbar-jquery3.2-skip
Jul 23, 2020
Merged

Tests: Skip a scrollbar test in jQuery 3.2#1927
mgol merged 1 commit into
jquery:masterfrom
mgol:tests-scrollbar-jquery3.2-skip

Conversation

@mgol
Copy link
Copy Markdown
Member

@mgol mgol commented Jun 24, 2020

jQuery 3.2 incorrectly handle scrollbars in WebKit/Blink-based browsers.
This is fixed in version 3.3, see jquery/jquery#3589.
As the data here comes from jQuery directly and the changes to fix it
are non-trivial: jquery/jquery#3656, just accept
that scrollbar data in this jQuery version is inaccurate.

Ref jquery/jquery#3589
Ref jquery/jquery#3656

jQuery 3.2 incorrectly handle scrollbars in WebKit/Blink-based browsers.
This is fixed in version 3.3, see jquery/jquery#3589.
As the data here comes from jQuery directly and the changes to fix it
are non-trivial: jquery/jquery#3656, just accept
that scrollbar data in this jQuery version is inaccurate.

Ref jquery/jquery#3589
Ref jquery/jquery#3656
@mgol mgol added this to the 1.13 milestone Jun 24, 2020
@mgol mgol requested review from arschmitz and fnagel June 24, 2020 16:31
Copy link
Copy Markdown
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by reading

@mgol mgol requested a review from a team June 25, 2020 16:53
@mgol mgol merged commit b8ec78a into jquery:master Jul 23, 2020
@mgol mgol deleted the tests-scrollbar-jquery3.2-skip branch July 23, 2020 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants