Upgrade css-nano and mocha to fix security issues #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Update
cssnanoandmochato fix npm security issuesDid you add tests for your changes?
Ran tests, there was one test failing and that was the keyframe-test. Didn't seem like anything important though. A comment was removed from the new output, and a bit more compacted (I guess
cssnanojust does it's job better). I also symlinked the module to test againt a studio. Could not see any issues.If relevant, did you update the README?
Not relevant.
Summary
Updated cssnano to avoid
https://nodesecurity.io/advisories/788Does this PR introduce a breaking change?
No
Other information
Also upgraded
mochato latest version because there were some security issues there as well.