Skip to content

Updates clean-css dependency to version 5. - #89

Open
jakubpawlowicz wants to merge 1 commit into
scniro:masterfrom
jakubpawlowicz:master
Open

Updates clean-css dependency to version 5.#89
jakubpawlowicz wants to merge 1 commit into
scniro:masterfrom
jakubpawlowicz:master

Conversation

@jakubpawlowicz

Copy link
Copy Markdown

Version 5 disables rebasing as default so tests changed accordingly.

If you need any help with additional tests or with releasing it, please just let me know! 🍺

@jakubpawlowicz

Copy link
Copy Markdown
Author

Since this is a major version change (incompatible with 4.x) you may have to release it by bumping gulp-clean-css version to 5.0.

Version 5 disables rebasing as default so tests changed accordingly.
@sirwalterious

Copy link
Copy Markdown

@scniro Any progress with this PR? We're facing a bug in clean-css, and would like to update to 5.1.x.

@cb-eli

cb-eli commented Oct 14, 2021

Copy link
Copy Markdown

Please merge

@iradovanovic

Copy link
Copy Markdown

Please merge this if is a fix. Or this project is dead?

@shrpne

shrpne commented Nov 11, 2022

Copy link
Copy Markdown

@scniro friendly reminder, please merge it

@ChaosEngine

Copy link
Copy Markdown

FWIW: You can do this in package.json to enforce usage of clean-css-5.*:

	"overrides": {
		"clean-css": ">=5.3.1"
	}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants