Skip to content

Deal with disable option on create #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scottgonzalez merged 10 commits into from
Sep 22, 2015
Merged

Deal with disable option on create #1

scottgonzalez merged 10 commits into from
Sep 22, 2015

Conversation

@jzaefferer
Copy link

@jzaefferer jzaefferer commented Sep 21, 2015

Building on top of jquerygh-1599, this fixes missing or redundant handling of the disabled option on create. The only missing widget is tabs. From my comment on the original PR:

Tabs is not working correctly, for example it ends up with the ui-tabs-disabled class when only setting specific tabs, like disabled: [1, 2]. Due to the array variant I haven't yet figured out what to do here.

@jzaefferer
Copy link
Author

jzaefferer commented Sep 21, 2015

This wasn't really supposed to be a PR on your fork :/

scottgonzalez
scottgonzalez reviewed Sep 21, 2015
View reviewed changes
ui/widgets/accordion.js Outdated
Copy link
Owner

@scottgonzalez scottgonzalez Sep 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already happens in the call to ._super() above.

@scottgonzalez
Copy link
Owner

scottgonzalez commented Sep 21, 2015

For tabs, you should be able to just rename ._setupDisabled(). You can drop the conditional in ._setOptions() as well.

@scottgonzalez scottgonzalez mentioned this pull request Sep 21, 2015
Closed
@jzaefferer
Accordion: Handle disabled option on create, through _setOptionDisabled
8922512 
Ref #9151
@jzaefferer
Dialog: Override disabled option on create, force always-enabled state
a747ab0 
Without this, _on will still respect the disabled option and ends up
preventing closing the dialog.

Ref #9151
@jzaefferer
Draggable: Remove redundant handling of disabled class on create
5ede8f4 
_setOptionDisabled in $.Widget is now handling that.

Ref #9151
@jzaefferer
Menu: Remove redundant handling of disabled option on create
4a59488 
Ref #9151
@jzaefferer
Progressbar: Handle disabled option on create, using _setOptionDisabled
2104241 
Ref #9151
@jzaefferer
Selectmenu: Remove redundant handling of disabled option on create
850fe6a 
Ref #9151
@jzaefferer
Slider: Remove redundant handling of disabled option on create
ade17bf 
Ref #9151
@jzaefferer
Spinner: Remove redundant handling of disabled option on create
2136be3 
Ref #9151
@jzaefferer
Tooltip: Don't apply disabled style changes on create
19c7852 
Ref #9151
@jzaefferer
Tabs: Adjust handling of disabled option, using _setOptionDisabled
80f85e0 
Tabs support multiple values to disable individual tabs. Only add the
ui-tabs-disabled class when all tabs are disabled.

Ref #9151
@jzaefferer
Copy link
Author

jzaefferer commented Sep 22, 2015

Updated. Removed all the redundant calls in setOption. Updated tooltip to use _setOptionDisabled.

Updated tabs, renaming to _setupDisabled to _setOptionDisabled. It still calls _setOptionDisabled in _refresh, which is also called on create. I added an explicit _toggleClass call to only add "ui-tabs-disabled" when all tabs are disabled.

@scottgonzalez scottgonzalez merged commit 80f85e0 into scottgonzalez:disabled-setter Sep 22, 2015
@jzaefferer jzaefferer deleted the disabled-setter2 branch September 30, 2015 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jzaefferer @scottgonzalez