Refactoring again :-)#10
Conversation
Conflicts: config.mk sjcl.js
Add a JavaScript parser/compressor/beautifier as submodule: https://github.com/mishoo/UglifyJS Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com>
Signed-off-by: Alexey Gladkov <gladkov.alexey@gmail.com>
Add uglifyjs as submodule THX legion!
…, made comments and max data size configurable
|
Updated change list:
|
|
Any ideas why sebsauvage has discontinued the development? |
|
I don't know. Maybe he is just busy with work, other projects or is on holiday. He has stated, that he wants to keep the project small and lightweight. So maybe he finds my changes to big. Of course, since this is GitHub, anybody is free to fork and send patches to any branch of the project. I have already incorporated patches that i liked and will do so in the future. Anybody is free to use my or any other branch. But I will continue to send my patches to sebsauvage. I can also provide a part of my fork as patch to his original build, if he finds my branch to big or does not like some of the features it contains. |
|
Hi, IMHO this refactoring thing is indeed far from the "small and lightweight" initial goal. I peeked into it and I must say (without any intention to offense) that you all transformed the code in something that is unreadable for me, whereas the code of sebsauvage, even if it isn't the most elegant or modular, had the advantage to be quite concise and understandable (in my humble opinion). I think it's due to the MVC pattern, maybe a little overkill for such a small project. I don't say it is bad, this refactoring allows the code to be more modular, and facilitates future improvements (and thus is good for this purpose), but I do not recognize anymore the original project in it, that's all. And as you say, that's what is good at Github: freedom to fork, patch, improve, submit. We'll see what sebsauvage thinks of this pull request sooner or later, but in any case it's possible to follow your valuable branch if one likes it. The rest of the features are very interesting though, gook work! |
jsdoc: fix param names in misc.cachedPbkdf2
* Fixed bug: when data is a number, it is now added to this._pools * Fixed bug: throws an exception when data is an object but not an array of numbers * Removed unused variable "ty" sjcl.random._loadTimeCollector(): * Fixed bug: now passes a number into sjcl.random.addEntropy() instead of an object
Fixed bug: Now accepts Uint32Array for data
sjcl.random.addEntropy() and sjcl.random._loadTimeCollector() are broken
…at much and also the whole trust of zerobin rests in the JS code, so some people might feel safer if the can read a servers JS files.
cleaned up CSS, changed template to output clean XHTML 5, added unit tests for 60% of the code, found a few bugs by doing that and fixed them
problem with code prettifier, fixed some display bugs
folder of a domain or subdomain. fixes #2
|
Hello. Sorry for not following ZeroBin closer, but I was really busy. You did a great job refactoring and adding internal features to ZeroBin, but - as zertrin said - I'm afraid we are moving away from the initial minimalism of ZeroBin. I will not merge this request. Congrats for the great job anyway ! |
Merged legions syntax highlighting patch. THX-a-lot!
additional changes include: