Refactored Code#15
Closed
SchumacherFM wants to merge 1 commit into
Closed
Conversation
…once with require, removed last ?>
Author
|
Please add first the other pull request before I submit my changes. |
wware
pushed a commit
to wware/ZeroBin
that referenced
this pull request
Sep 8, 2015
…trigger it and reworked persistence classes to through exceptions rather to fail silently
wware
pushed a commit
to wware/ZeroBin
that referenced
this pull request
Sep 8, 2015
…sauvage#15) - fixing missing url conversion in highlighted text (point 2. # 15)
wware
pushed a commit
to wware/ZeroBin
that referenced
this pull request
Sep 8, 2015
- asking again if password is wrong - display error if user cancels dialog - use password to encrypt comments, too (password is "stored" in the password field) - store password in sessionStorage when posting a comment so, that it doesn't have to typed in again, but clear sessionStorage as soon as password is retrieved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I want to contribute to your Zerobin. Here is my first pull request.
"Moved functions from index.php to functions.inc.php, replace require_…
…once with require, removed last ?>"
Cheers, Cyrill