Implement file attachments feature#31
Closed
vikstrous wants to merge 1 commit into
Closed
Conversation
Author
|
Since this project is mostly abandoned, I'm building on top of elrodo and CashWilliams's forks. |
Owner
|
Hello. This project is not abandonned. I was (too) busy. I will not implement file attachement to ZeroBin. I do not want to be the new Mega. ZeroBin will stay a text-sharing application. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added support for a single file to be attached to any message.
Note that it's a little hacky in some places. I'm open to suggestions about how to improve it.
The data per message is now double because of this. I'm wondering if it's a good idea to restrict the size of the total data instead of the message and attachment individually. That might make more sense if a multiple file attachment feature is added.
Also, if ZeroBin is to support files, it might be a good idea to check the file size in JavaScript before uploading.
Tested in Firefox 18.0.1 on Ubuntu 12.10. I don't currently have compatibility checks.
Let me know what you think.