Skip to content

URL shortener#32

Closed
ziirish wants to merge 1 commit into
sebsauvage:masterfrom
ziirish:master
Closed

URL shortener#32
ziirish wants to merge 1 commit into
sebsauvage:masterfrom
ziirish:master

Conversation

@ziirish
Copy link
Copy Markdown

@ziirish ziirish commented Feb 25, 2013

Hi sebsauvage,

here is a little patch to add a "shorten url" option using a local webservice such as yourls ( http://yourls.org/#API )

Of course using the url shortener makes the url "publicly" available thru the url shortener database.

@kpankonen
Copy link
Copy Markdown

this was already a feature that was removed - 241c75a

@ziirish
Copy link
Copy Markdown
Author

ziirish commented Feb 25, 2013

I know this feature was removed, but it was using an external webservice.

Here I'm using a local one so even if the URLs are stored in the shortener service database (which is not a good idea for critical pastes) I can still remove it which is not the case if you are using a third-party url shortener.

Plus, the $.get does not allow cross site requests (unless you are using jsonp) so this implementation limits the risk of "privacy leak".

@sebsauvage
Copy link
Copy Markdown
Owner

Using a local url shortener implies that the server knows the key, which defeats the purpose of ZeroBin itself.

@sebsauvage sebsauvage closed this Feb 26, 2013
@ziirish
Copy link
Copy Markdown
Author

ziirish commented Feb 26, 2013

Of course using a url shortener makes your paste "unsecure". But let's take a simple example: if you want to share your paste on twitter (I know this is totally fool), they will shorten your url and then makes your paste very unsecure.
Now I use my own url shortener, I can share my shorten URL on twitter, they reshorten it, but if I want to disable my link, I can.

@sebsauvage
Copy link
Copy Markdown
Owner

So you want to be able to disable the link without disabling the paste itself ?

@ziirish
Copy link
Copy Markdown
Author

ziirish commented Feb 26, 2013

Yes, that's the idea.

Plus a little "eyecandy" URL thing assuming my paste is not so "secret"

Maybe I should add a warning message/pop-up while using this option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants