File lock for write on /data/traffic_limiter.php#61
Merged
Conversation
|
If we assume that without a lock, multiple simultaneous writes can corrupt a file, or simultaneous reads and writes can corrupt what is read, then it might be possible to turn the lack-of-lock into a remote code execution vulnerability, since the file is executed as PHP code. |
sebsauvage
added a commit
that referenced
this pull request
Feb 3, 2014
File lock for write on /data/traffic_limiter.php
Owner
|
Thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an LOCK_EX for write on file /data/traffic_limiter.php for preventing that one instance is reading data while a write by another instance is not finished.