Code modularization#8
Closed
elrido wants to merge 2 commits into
Closed
Conversation
…, started working on a PDO based DB connector
Contributor
|
Awesome work :) But, conf.ini is unprotected :p |
…to lib & cfg directories. If those are not present, the application will create them for you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Sebsauvage,
First of all: Thank you very much for sharing this nice project of yours!
I like the simple yet disruptive idea of ZeroBin very much and i am really impressed what is possible with javascript. As my javascript skills are not that great, i am sorry, i can't support you on that side of ZeroBin. But as a PHP coder i wanted to at least help you with that part of the project. One of the first modification i made when i played around with ZeroBin was to store the data outside of the webservers document root. While hunting for all those paths in the skript, i learned a bit about the working of the code.
This weekend i took the time to refactor your project a little. The goal was to make it a bit more modular and to add a mechanism for some basic configuration. The path prefix for includes can now be changed in the index file. Other settings, like the path where the pastes are stored or the traffic limit can be configured through an ini file.
One next step could be an alternative storage model for databases. But that is up for another weekend.
Hope you can to use some of my changes.
El RIDO