Skip to content

:nth-child(-/**/n+2) should parse #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Manishearth opened this issue Jun 3, 2017 · 5 comments
Closed

:nth-child(-/**/n+2) should parse #153

Manishearth opened this issue Jun 3, 2017 · 5 comments

Comments

@Manishearth
Copy link
Member

According to the spec, spaces are not allowed between +n and -n in nth-child, however it says nothing about comments. Chrome allows this, and with https://bugzilla.mozilla.org/show_bug.cgi?id=1364009, Firefox will too. We should as well.

cc @SimonSapin @dbaron
Manishearth added a commit to Manishearth/rust-cssparser that referenced this issue Jun 3, 2017
@Manishearth
Parse nth-child(-/*comment*/n+b) (fixes servo#153)
949ba19
@Manishearth Manishearth mentioned this issue Jun 3, 2017
Closed
Manishearth added a commit to Manishearth/rust-cssparser that referenced this issue Jun 3, 2017
@Manishearth
Parse nth-child(-/*comment*/n+b) (fixes servo#153)
90ede21
@SimonSapin
Copy link
Member

+/**/n+2 matches '+'?† n <signed-integer>, but -/**/n+2 doesn’t match the grammar.

@emilio
Copy link
Member

emilio commented Jun 4, 2017

Still is what's accepted by other browsers, isn't it? Worth filing a spec issue I guess.

@Manishearth Manishearth mentioned this issue Jun 4, 2017
Closed
@SimonSapin
Copy link
Member

shrugs
For once I think this is something that only ever happens in test cases.

@Manishearth
Copy link
Member Author

Yeah, the comments don't matter as much.

Though gecko has an absurd number of tests for that 😄

@SimonSapin
Copy link
Member

Closing in favor of w3c/csswg-drafts#1498.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parse nth-child(-/*comment*/n+b) Manishearth/rust-cssparser
3 participants
@SimonSapin @emilio @Manishearth