Add comments to justify unsafe blocks.
#119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonSapin
commented
Feb 14, 2017
| fn consume_escape_and_write(tokenizer: &mut Tokenizer, bytes: &mut Vec<u8>) { | ||
| use std::io::Write; | ||
| write!(bytes, "{}", consume_escape(tokenizer)).unwrap(); | ||
| bytes.extend(consume_escape(tokenizer).encode_utf8(&mut [0; 4]).as_bytes()) |
There was a problem hiding this comment.
Note that encode_utf8 is stable since Rust 1.15.
I’m not convinced this requires a breaking version number increment, but regardless so we’re doing one in #118.
|
@bors-servo r+ Yeah, let's roll that change into the colors thing. |
|
📌 Commit 6a6f157 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 14, 2017
Add comments to justify `unsafe` blocks. <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/119) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is