Skip to content

Make match_ignore_ascii_case more efficient, add ascii_case_insensitive_phf_map #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 25, 2017
Merged

Make match_ignore_ascii_case more efficient, add ascii_case_insensitive_phf_map #122

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
63c2044
Update syn and encoding_rs
SimonSapin Feb 24, 2017
0592bea
Use docs.rs for docs.
SimonSapin Feb 24, 2017
808922a
Use a proc-macro to optimize match_ignore_ascii_case
SimonSapin Feb 24, 2017
0192030
Add a ascii_case_insensitive_phf_map macro, use it for color keywords.
SimonSapin Feb 25, 2017
5a17750
Add comments to explain new `unsafe` code.
SimonSapin Feb 25, 2017
ea6843d
Don’t borrow $input in match_ignore_ascii_case!
SimonSapin Feb 25, 2017
983529f
Document macros.
SimonSapin Feb 25, 2017
b0c427d
Remove the already-lowercase requirement in ascii_case_insensitive_ph…
SimonSapin Feb 25, 2017
78996fc
Increment version for breaking changes in match_ignore_ascii_case
SimonSapin Feb 25, 2017
0db4f8e
Rename internal things per what they do.
SimonSapin Feb 25, 2017
c85990a
Be more robust regarding attribute ordering in proc macros.
SimonSapin Feb 25, 2017
df6892b
Support macros being used in a module with #[deny(unsafe_code)]
SimonSapin Feb 25, 2017
136c97a
match_ignore_ascii_case: extend lifetime of input.
SimonSapin Feb 25, 2017
138ccaf
Remove an obsolete bit of comment.
SimonSapin Feb 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support macros being used in a module with #[deny(unsafe_code)]
  • Loading branch information
@SimonSapin
SimonSapin committed Feb 25, 2017
commit df6892b17b17d94e50a9c96964c6da2e43f65b67
16 changes: 8 additions & 8 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,14 +226,14 @@ macro_rules! _cssparser_internal__to_lowercase {
#[allow(dead_code)]
struct Dummy2;

// MAX_LENGTH is generated by cssparser__match_ignore_ascii_case__max_len
let mut buffer: [u8; MAX_LENGTH] =
// `buffer` is only used in `_internal__to_lowercase`,
// which initializes with `copy_from_slice` the part of the buffer it uses,
// before it uses it.
unsafe {
::std::mem::uninitialized()
};
// mem::uninitialized() is ok because `buffer` is only used in `_internal__to_lowercase`,
// which initializes with `copy_from_slice` the part of the buffer it uses,
// before it uses it.
#[allow(unsafe_code)]
// MAX_LENGTH is generated by cssparser__max_len
let mut buffer: [u8; MAX_LENGTH] = unsafe {
::std::mem::uninitialized()
};
let $output = $crate::_internal__to_lowercase(&mut buffer, $input);
}
}
Expand Down