Skip to content

Revert parse error changes #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2017
Merged

Revert parse error changes #148

merged 1 commit into from
May 28, 2017

Conversation

jdm
Copy link
Member

@jdm jdm commented May 18, 2017

The API changes should not merge until the downstream consumers are ready.

This reverts commit 0a70d22, reversing
changes made to fc0bdcd.


This change is Reviewable

This reverts commit 0a70d22, reversing
changes made to fc0bdcd.
@emilio
Copy link
Member

emilio commented May 28, 2017

@bors-servo r+

  • This is blocking the serde bump.

I really hope we get the error reporting bits right soon though!

@bors-servo
Copy link
Contributor

📌 Commit 8ac1afd has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit 8ac1afd with merge f6fa9b5...

bors-servo pushed a commit that referenced this pull request May 28, 2017
Revert parse error changes

The API changes should not merge until the downstream consumers are ready.

This reverts commit 0a70d22, reversing
changes made to fc0bdcd.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/148)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: emilio
Pushing f6fa9b5 to master...

@bors-servo bors-servo merged commit 8ac1afd into servo:master May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants