Skip to content

Use char::from_u32 to cast to char #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Use char::from_u32 to cast to char #15

wants to merge 1 commit into from

Conversation

brson
Copy link
Contributor

@brson brson commented Sep 6, 2013

No description provided.

@brson
Copy link
Contributor Author

brson commented Sep 6, 2013

Tests failing

@brson brson closed this Sep 6, 2013
@SimonSapin
Copy link
Member

I think that char::from_u32 returns None exactly when, per spec, this function should return U+FFFD. (Excluding surrogates was added recently to the spec.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brson @SimonSapin