Return meaningful error values when parsing #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should not be merged until servo/servo#16752 is ready to merge. |
|
r? @SimonSapin for the changes in 63bdb44. |
|
|
|
Reviewed 4 of 8 files at r2, 3 of 3 files at r3, 1 of 1 files at r4. src/parser.rs, line 75 at r4 (raw file):
This makes the tokenizer effectively public. Please remove the Comments from Reviewable |
Rewrite some public APIs to support returning error types that contain borrowed pointers to the parser's input.
543eae7 to
970e1ca
Compare
|
@bors-servo: r=SimonSapin |
|
📌 Commit 970e1ca has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 9, 2017
Return meaningful error values when parsing This is #143 with an extra commit added to accommodate changes requested in servo/servo#16752. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/155) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #143 with an extra commit added to accommodate changes requested in servo/servo#16752.
This change is