Serialize currentcolor as canonicalized form #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo delegate+ r=me yeah, do a minor version bump so that we can pull in the new version. |
|
@bors-servo r=Manishearth |
|
@bors-servo ping |
|
@bors-servo are you still there? |
|
@bors-servo r+ |
1 similar comment
|
@bors-servo r+ |
|
📌 Commit acbef22 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 21, 2017
Serialize currentcolor as canonicalized form Serialize currentcolor as canonicalized form instead of currentColor. This is needed for servo/servo#15397 I'm not sure about version bump though. Is that a breaking change? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/162) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
|
I think this does not need to be a breaking change. Since 0.17.0 is not yet on crates.io, we can still change this to 0.16.1. I’m not sure what @Manishearth meant to say, since "minor" could either mean "not breaking" or "second component, between major and micro components" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize currentcolor as canonicalized form instead of currentColor. This is needed for servo/servo#15397
I'm not sure about version bump though. Is that a breaking change?
This change is