Provide ParserInput::new_with_line_number_offset #184
Conversation
This patch adds ParserInput::new_with_line_number_offset, a new constructor that calls Tokenizer::with_first_line_number. Servo has its own code for tracking the initial line number, but that code can be replaced by this.
|
Oh yes, I meant to do that when adding (Note however that current cssparser versions cause test failures in Servo and Gecko and cannot land there at the moment. I’m working on that in servo/servo#18171.) @bors-servo r+ |
|
📌 Commit 4d42b6a has been approved by |
Provide ParserInput::new_with_line_number_offset This patch adds ParserInput::new_with_line_number_offset, a new constructor that calls Tokenizer::with_first_line_number. Servo has its own code for tracking the initial line number, but that code can be replaced by this. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/184) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Thanks. I've CC'd myself on that bug. I'll wait until it is resolved, and then submit my servo PR. |
|
You can see it here: https://github.com/tromey/servo/tree/cssparser-line-number-offset Not ready for merge of course, at least Cargo.lock isn't updated. |
|
servo/servo#18171 has some extra failures that are specific to changes in that PR, but I think cssparser changes can land now, with #185 and version 0.19.5. I’m doing that in https://bugzilla.mozilla.org/show_bug.cgi?id=1393967. |
This patch adds ParserInput::new_with_line_number_offset, a new
constructor that calls Tokenizer::with_first_line_number. Servo has its
own code for tracking the initial line number, but that code can be
replaced by this.
This change is