Clarify some dead code #189
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
next_token has this code:
if is_ident_start(tokenizer) { IDHash(consume_name(tokenizer)) }
else if !tokenizer.is_eof() && match tokenizer.next_byte_unchecked() {
b'a'...b'z' | b'A'...b'Z' | b'0'...b'9' | b'-' | b'_' => true,
b'\\' => !tokenizer.has_newline_at(1),
_ => !b.is_ascii(),
} { Hash(consume_name(tokenizer)) }
I noticed that the `_` case incorrectly checks whether `b` is ASCII,
rather than the current byte.
However, on further inspection, it turns out that this can't be run,
because all such cases would have been filtered out by is_ident_start.
This patch clarifies this code by removing the dead cases and adding a
comment.
|
Good catch, thanks! @bors-servo r+ |
|
📌 Commit 678736c has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 29, 2017
Clarify some dead code
next_token has this code:
if is_ident_start(tokenizer) { IDHash(consume_name(tokenizer)) }
else if !tokenizer.is_eof() && match tokenizer.next_byte_unchecked() {
b'a'...b'z' | b'A'...b'Z' | b'0'...b'9' | b'-' | b'_' => true,
b'\\' => !tokenizer.has_newline_at(1),
_ => !b.is_ascii(),
} { Hash(consume_name(tokenizer)) }
I noticed that the `_` case incorrectly checks whether `b` is ASCII,
rather than the current byte.
However, on further inspection, it turns out that this can't be run,
because all such cases would have been filtered out by is_ident_start.
This patch clarifies this code by removing the dead cases and adding a
comment.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/189)
<!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
next_token has this code:
I noticed that the
_case incorrectly checks whetherbis ASCII,rather than the current byte.
However, on further inspection, it turns out that this can't be run,
because all such cases would have been filtered out by is_ident_start.
This patch clarifies this code by removing the dead cases and adding a
comment.
This change is