Preserve sourceURL comment in parser #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I assume you’re want this on crates.io, so r=me with the version number incremented. |
In addition to the sourceMappingURL comment, there is a second special comment, "sourceURL", that can be used to set the "display name" of a style sheet for developer tools. This name is also used as the base URL for the source-map URL resolution algorithm. sourceURL is described here: https://blog.getfirebug.com/2009/08/11/give-your-eval-a-name-with-sourceurl/ The relevant Firefox bug is here: https://bugzilla.mozilla.org/show_bug.cgi?id=880831
7cf88a7 to
7e3b85d
Compare
|
I saw by chance that you had updated this PR but did not receive an email notification for that. I’ve seen some github notifications for further pushes to PR but they don’t seem to always happen… I don’t know if there’s a specific situation that causes that. Anyway, please also comment (or ping on IRC, or something) when you push. @bors-servo r+ |
|
📌 Commit 7e3b85d has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 14, 2017
Preserve sourceURL comment in parser In addition to the sourceMappingURL comment, there is a second special comment, "sourceURL", that can be used to set the "display name" of a style sheet for developer tools. This name is also used as the base URL for the source-map URL resolution algorithm. sourceURL is described here: https://blog.getfirebug.com/2009/08/11/give-your-eval-a-name-with-sourceurl/ The relevant Firefox bug is here: https://bugzilla.mozilla.org/show_bug.cgi?id=880831 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/197) <!-- Reviewable:end -->
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 7e3b85d has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Sep 14, 2017
Preserve sourceURL comment in parser In addition to the sourceMappingURL comment, there is a second special comment, "sourceURL", that can be used to set the "display name" of a style sheet for developer tools. This name is also used as the base URL for the source-map URL resolution algorithm. sourceURL is described here: https://blog.getfirebug.com/2009/08/11/give-your-eval-a-name-with-sourceurl/ The relevant Firefox bug is here: https://bugzilla.mozilla.org/show_bug.cgi?id=880831 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/197) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the sourceMappingURL comment, there is a second special
comment, "sourceURL", that can be used to set the "display name" of a
style sheet for developer tools. This name is also used as the base
URL for the source-map URL resolution algorithm. sourceURL is
described here:
https://blog.getfirebug.com/2009/08/11/give-your-eval-a-name-with-sourceurl/
The relevant Firefox bug is here:
https://bugzilla.mozilla.org/show_bug.cgi?id=880831
This change is