Skip to content

Conversation

@Eijebong
Copy link
Contributor

@Eijebong Eijebong commented Jan 11, 2018

This change is Reviewable

@SimonSapin
Copy link
Member

In macros/lib.rs, could we convert between proc_macro::TokenStream and proc_macro2::TokenStream without going explicitly through String? That way enabling the proc_macro2/nightly cargo feature would preserve span information and produce better error message if something fails to compile.


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


build/match_byte.rs, line 20 at r1 (raw file):

    let mut source = String::new();
    File::open(from).unwrap().read_to_string(&mut source).unwrap();
    let tts = syn::parse_file(&source).expect("Parsing rules.rs module");

Rename tts (token trees) to something like ast?


Comments from Reviewable

@SimonSapin
Copy link
Member

Never mind, I forgot that these conversions to/from strings are in precedural-masquerade, refactoring that would be more involved than I thought.

@bors-servo r+


Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@bors-servo
Copy link
Contributor

📌 Commit a244c3c has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit a244c3c with merge 39a4706...

bors-servo pushed a commit that referenced this pull request Jan 11, 2018
Update syn to 0.12 and quote to 0.4

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/211)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing 39a4706 to master...

@bors-servo bors-servo merged commit a244c3c into servo:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants