Add the extra-traits feature to syn in the cssparser-macros crate #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is needed for that crate to compile but since CI was never compiling it on its own and that cargo features are additive, this never got caught. Fixes servo#214
Contributor
|
@bors-servo r+ |
Contributor
|
📌 Commit 68646fd has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Mar 9, 2018
Add the extra-traits feature to syn in the cssparser-macros crate This feature is needed for that crate to compile but since CI was never compiling it on its own and that cargo features are additive, this never got caught. Fixes #214 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/215) <!-- Reviewable:end -->
Contributor
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is needed for that crate to compile but since CI was never
compiling it on its own and that cargo features are additive, this never
got caught.
Fixes #214
This change is