Skip to content

Update syn, quote and proc-macro2 #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2018
Merged

Update syn, quote and proc-macro2 #217

merged 2 commits into from
Apr 10, 2018

Conversation

hcpl
Copy link
Contributor

@hcpl hcpl commented Apr 1, 2018 •
edited by larsbergstrom
Loading

This change is Reviewable

@Eijebong
Copy link
Contributor

Eijebong commented Apr 1, 2018

If this could wait a little bit, it would be nice. We already have two versions of syn in servo

@hcpl
Copy link
Contributor Author

hcpl commented Apr 1, 2018

Sure! I am trying to make the ecosystem transition as soon as possible to reap the benefits for doing so, but I wouldn't want to have 3 versions of the same dependencies either.

@SimonSapin SimonSapin mentioned this pull request Apr 1, 2018
Closed
4 tasks
@SimonSapin
Copy link
Member

Let’s coordinate this with other Servo dependencies: servo/servo#20497

@SimonSapin
Copy link
Member

Looks good, please also increment the version number of the two crates. Thanks!

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@SimonSapin
Copy link
Member

@bors-servo r+

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@bors-servo
Copy link
Contributor

📌 Commit a8011a5 has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit a8011a5 with merge ecd0a3d...

bors-servo pushed a commit that referenced this pull request Apr 10, 2018
Auto merge of #217 - hcpl:update-syn-quote-proc-macro2, r=SimonSapin
ecd0a3d 
Update `syn`, `quote` and `proc-macro2`

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/217)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing ecd0a3d to master...

@bors-servo bors-servo merged commit a8011a5 into servo:master Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hcpl @Eijebong @SimonSapin @bors-servo