Skip to content

Have UnicodeRange not serialize question marks. #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2018

Conversation

upsuper
Copy link
Contributor

@upsuper upsuper commented Apr 3, 2018

No browser does that. This causes test failures in Gecko.


This change is Reviewable

@upsuper
Copy link
Contributor Author

upsuper commented Apr 3, 2018

r? @SimonSapin

@upsuper
Copy link
Contributor Author

upsuper commented Apr 3, 2018

@bors-servo r=SimonSapin

@bors-servo
Copy link
Contributor

📌 Commit 51f920d has been approved by SimonSapin

@bors-servo
Copy link
Contributor

⌛ Testing commit 51f920d with merge a2abf47...

bors-servo pushed a commit that referenced this pull request Apr 3, 2018
Have UnicodeRange not serialize question marks.

No browser does that. This causes test failures in Gecko.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/218)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - status-travis
Approved by: SimonSapin
Pushing a2abf47 to master...

@bors-servo bors-servo merged commit 51f920d into servo:master Apr 3, 2018
@upsuper upsuper deleted the unicode-range branch April 3, 2018 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants