Expose byte index in tokenizer's position. #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @SimonSapin |
|
@bors-servo r+ |
|
📌 Commit ddb7384 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 29, 2019
Expose byte index in tokenizer's position. I need it to finish my implementation of Properties and Values syntax. It works on bytes rather than CSS tokens, but it calls the consume a name algorithm, for which I'm using cssparser. However I need to know how much of the input was actually consumed after consuming a name to continue the parse. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/249) <!-- Reviewable:end -->
|
💔 Test failed - checks-travis |
|
@bors-servo retry |
bors-servo
pushed a commit
that referenced
this pull request
May 29, 2019
Expose byte index in tokenizer's position. I need it to finish my implementation of Properties and Values syntax. It works on bytes rather than CSS tokens, but it calls the consume a name algorithm, for which I'm using cssparser. However I need to know how much of the input was actually consumed after consuming a name to continue the parse. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/249) <!-- Reviewable:end -->
|
💔 Test failed - checks-travis |
I need it to finish my implementation of Properties and Values syntax. It works on bytes rather than CSS tokens, but it calls the consume a name algorithm, for which I'm using cssparser. However I need to know how much of the input was actually consumed afterwards to continue the parse.
ddb7384 to
6649a8f
Compare
|
@bors-servo r=jdm |
|
📌 Commit 6649a8f has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 29, 2019
Expose byte index in tokenizer's position. I need it to finish my implementation of Properties and Values syntax. It works on bytes rather than CSS tokens, but it calls the consume a name algorithm, for which I'm using cssparser. However I need to know how much of the input was actually consumed after consuming a name to continue the parse. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/249) <!-- Reviewable:end -->
|
☀️ Test successful - checks-travis |
emilio
added a commit
to emilio/css-typed-om-syntax
that referenced
this pull request
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need it to finish my implementation of Properties and Values syntax.
It works on bytes rather than CSS tokens, but it calls the consume a name
algorithm, for which I'm using cssparser.
However I need to know how much of the input was actually consumed
after consuming a name to continue the parse.
This change is