Skip to content

Use MaybeUninit when available #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2019
Merged

Use MaybeUninit when available #252

merged 2 commits into from
Jul 6, 2019

Conversation

SimonSapin
Copy link
Member

@SimonSapin SimonSapin commented Jul 6, 2019

Fix deprecation warnings for mem::uninitialized. (They also affected other crates, since it’s used in a public macro.)


This change is Reviewable

Fix some deprecation warnings
Fix deprecation warnings for mem::uninitialized.
(They also affected other crates, since it’s used in a public macro.)
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didn't know about autocfg :)

@emilio
Copy link
Member

emilio commented Jul 6, 2019

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 376f4c6 has been approved by emilio

bors-servo pushed a commit that referenced this pull request Jul 6, 2019
Use MaybeUninit when available

Fix deprecation warnings for `mem::uninitialized`. (They also affected other crates, since it’s used in a public macro.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/252)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

⌛ Testing commit 376f4c6 with merge 5918dbf...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: emilio
Pushing 5918dbf to master...

@bors-servo bors-servo merged commit 376f4c6 into master Jul 6, 2019
@SimonSapin SimonSapin deleted the uninit branch July 6, 2019 12:53
@SimonSapin
Copy link
Member Author

I learned about it recently by looking at hashbrown

SimonSapin added a commit that referenced this pull request Jul 6, 2019
`#[cfg(…)]` in a macro expansion is itself interpreted at the use site.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants