Replace deprecated std constants by associated constants. #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo r+ |
|
📌 Commit 15c2ec2 has been approved by |
bors-servo
added a commit
that referenced
this pull request
Nov 21, 2021
Replace deprecated std constants by associated constants. This PR aims to fix a few minor deprecation warnings. See https://blog.rust-lang.org/2020/04/23/Rust-1.43.0.html#library-changes and https://doc.rust-lang.org/stable/std/usize/index.html for details.
|
💔 Test failed - checks-github |
|
Looks like this has implications for the libraries minimum supported rust version. |
|
Ah, good catch - I did not check that! I guess merging this will have to wait until the min. rust version is 1.43 or higher then. |
|
@bors-servo r+
|
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 15c2ec2 has been approved by |
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a few minor deprecation warnings.
See https://blog.rust-lang.org/2020/04/23/Rust-1.43.0.html#library-changes and https://doc.rust-lang.org/stable/std/usize/index.html for details.