Skip to content

color: Don't allow commas in hwb() function. #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 24, 2021
Merged

color: Don't allow commas in hwb() function. #295

merged 1 commit into from
Dec 24, 2021

Conversation

emilio
Copy link
Member

@emilio emilio commented Dec 24, 2021

It's not allowed per spec, though perhaps it should?

I filed w3c/csswg-drafts#6911

It's not allowed per spec, though perhaps it should?

I filed w3c/csswg-drafts#6911
@emilio
Copy link
Member Author

emilio commented Dec 24, 2021

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit bf31c1d has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit bf31c1d with merge 5e3bf84...

@emilio
Copy link
Member Author

emilio commented Dec 24, 2021

@BorisChiou / @hiikezoe / @upsuper if any of you can sanity-check this it'd be great, though it's quite trivial.

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: emilio
Pushing 5e3bf84 to master...

@bors-servo bors-servo merged commit 5e3bf84 into master Dec 24, 2021
@emilio emilio deleted the hwb-fix branch December 24, 2021 18:45
Copy link
Contributor

@upsuper upsuper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants