Skip to content

Update itoa to 1.0 #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update itoa to 1.0 #296

wants to merge 1 commit into from

Conversation

DBLouis
Copy link

@DBLouis DBLouis commented Jan 25, 2022

No description provided.

@emilio
Copy link
Member

emilio commented Jan 25, 2022

Thanks! Do you have some perf numbers for this by any chance? It seems this will introduce an extra buffer copy (to the stack though, so maybe fine).

It'd be good to avoid it somehow, but maybe it's just faster, or old itoa also did this.

@DBLouis
Copy link
Author

DBLouis commented Jan 25, 2022

It seems that itoa::write was also using a buffer:
https://docs.rs/itoa/0.4.8/src/itoa/lib.rs.html#84-91

@DBLouis DBLouis closed this Apr 25, 2022
@emilio emilio mentioned this pull request May 18, 2022
Merged
@emilio
Copy link
Member

emilio commented May 18, 2022

Sorry for missing this! I merged this change in #302 and kept you as author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DBLouis @emilio