Update phf to 0.10 #300
Merged
Update phf to 0.10 #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we make a patch version bump of cssparser for this phf upgrade 🤔 ? |
|
It would be great if that's so. servo-selector also suffers from it. |
|
r? @emilio |
|
Yeah feel free to bump the minor version as well before landing? r=me either way |
emilio
approved these changes
Apr 28, 2022
|
It seems this needs to update the minimum rust version, see the CI jobs. I think that's probably fine, 1.36 is kinda ancient. |
|
Do you want to remove them (1.36) or set to the current one? |
|
@bors-servo r+ Thanks! |
|
📌 Commit 8ef116b has been approved by |
|
☀️ Test successful - checks-github |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phf 0.8 still uses rand_core version <0.6.2 which suffer from CVE-2021-27378.
Every crate depends on it will be warned by cargo audit.