Skip to content

Include 0.11 in the range of compatible phf versions. #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2022
Merged

Include 0.11 in the range of compatible phf versions. #306

merged 1 commit into from
Aug 7, 2022

Conversation

adamreichold
Copy link
Contributor

No description provided.

@adamreichold
Copy link
Contributor Author

Will have to cargo update --precise the phf dependency for the MSRV run...

@adamreichold
Copy link
Contributor Author

Will have to cargo update --precise the phf dependency for the MSRV run...

The step to downgrade the phf version for the MSRV job is a bit brittle because it references the current latest version of that crate. This can be avoided by using a bit of scripting like here or by checking in a separate Cargo.lock which can be copied in for the MSRV job if the maintainers prefer any of these slightly more involved solutions.

@emilio
Copy link
Member

emilio commented Aug 6, 2022

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 7c104fc has been approved by emilio

bors-servo added a commit that referenced this pull request Aug 6, 2022
@bors-servo
Auto merge of #306 - adamreichold:increase-phf-version-range, r=emilio
81f5966 
Include 0.11 in the range of compatible phf versions.

None
@bors-servo
Copy link
Contributor

⌛ Testing commit 7c104fc with merge 81f5966...

@bors-servo
Copy link
Contributor

💥 Test timed out

@adamreichold
Copy link
Contributor Author

I am sorry for making this complicated by messing up the quoting rules for GitHub expressions. 🤦🏽

@emilio
Copy link
Member

emilio commented Aug 7, 2022

@bors-servo r+

No problem, thanks!

@bors-servo
Copy link
Contributor

📌 Commit 9f936c0 has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit 9f936c0 with merge 707336b...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: emilio
Pushing 707336b to master...

@bors-servo bors-servo merged commit 707336b into servo:master Aug 7, 2022
@GPHemsley GPHemsley mentioned this pull request Dec 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio emilio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamreichold @emilio @bors-servo