Refactor color parser to use a generic as output #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactor allows the color parser to construct new color values directly, in stead of constructing a predefined color value and then forcing lib users to convert that type into whichever format they want to use in the end. Most common use case is that the color included in the lib, cssparser::Color, is good for serialization, but not well suited for doing calculations on.
4e0e53a to
5a345d6
Compare
emilio
approved these changes
Feb 6, 2023
|
@bors-servo r+ |
|
📌 Commit 5a345d6 has been approved by |
|
☀️ Test successful - checks-github |
1 similar comment
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor allows the color parser to construct new color values directly, in stead of constructing a predefined color value and then forcing lib users to convert that type into whichever format they want to use in the end.
Most common use case is that the color included in the lib, cssparser::Color, is good for serialization, but not well suited for doing calculations on.