Add none keyword #327
Merged
Add none keyword #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
☔ The latest upstream changes (presumably #328) made this pull request unmergeable. Please resolve the merge conflicts. |
emilio
reviewed
Mar 9, 2023
e647027 to
9bdf3bc
Compare
02295d9 to
4582f86
Compare
emilio
approved these changes
Mar 10, 2023
|
@bors-servo delegate+ (@tiaanl this allows you to |
|
✌️ @tiaanl can now approve this pull request |
|
@bors-servo r=emilio |
|
📌 Commit da5ea89 has been approved by |
|
☀️ Test successful - checks-github |
1 similar comment
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each color component, we allow the "none" keyword. The keyword will be kept in place for serialization. The "none" keyword is not allowed in the legacy syntax.
rgbandhslare handled special, because they support the legacy color syntax. They also cannot be combined, because rgb cares about the type of the components, and hsl does not.