Skip to content

Cleanup for crates.io release #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 27, 2023
Merged

Cleanup for crates.io release #329

merged 5 commits into from
Apr 27, 2023

Conversation

tiaanl
Copy link
Collaborator

@tiaanl tiaanl commented Mar 11, 2023

  • Add documentation where needed.
  • Remove #[repr(C)] from structs. These are not needed any more and doesn't really do anything now that the types are Option<_>.
  • Fix links so that they work in docs.
  • Small clippy fixes.

@emilio For publishing all the new color changes as 0.30 to crates.io, any other suggestions on what to clean up?

@tiaanl tiaanl marked this pull request as ready for review March 11, 2023 09:47
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this one. Looks good

@emilio
Copy link
Member

emilio commented Apr 27, 2023

@bors-servo r+

@bors-servo
Copy link
Contributor

📌 Commit 51cb57c has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit 51cb57c with merge 53ace36...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: emilio
Pushing 53ace36 to master...

@bors-servo bors-servo merged commit 53ace36 into servo:master Apr 27, 2023
@tiaanl tiaanl deleted the next branch April 29, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants