Allow macros to be imported with use instead of #[macro_use]
#330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonSapin
commented
Apr 19, 2023
| @@ -1487,7 +1487,7 @@ fn utf16_columns() { | |||
| #[test] | |||
| fn servo_define_css_keyword_enum() { | |||
| macro_rules! define_css_keyword_enum { | |||
| (pub enum $name:ident { $($variant:ident = $css:expr,)+ }) => { | |||
| (pub enum $name:ident { $($variant:ident = $css:pat,)+ }) => { | |||
There was a problem hiding this comment.
This is unrelated but avoids a error: expected literal compilation error (likely from a proc macro) with Rust 1.68.2. Maybe the compiler changed how macro_rules and proc-macros interact?
jdm
approved these changes
Apr 22, 2023
|
@bors-servo r=jdm |
|
📌 Commit 11f6aaf has been approved by |
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.