Skip to content

[css-nesting] Trivial-ish nesting API changes. #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2023
Merged

[css-nesting] Trivial-ish nesting API changes. #333

merged 2 commits into from
Apr 29, 2023

Conversation

emilio
Copy link
Member

@emilio emilio commented Apr 27, 2023

The API change is needed regardless (we need a declaration parser that also parses qualified rules).

The implementation details are a bit subject to change so make it opt-in.

@emilio emilio changed the title [wip] Nesting [css-nesting] Trivial-ish nesting API changes. Apr 27, 2023
@emilio emilio marked this pull request as ready for review April 27, 2023 16:20
@emilio
Copy link
Member Author

emilio commented Apr 27, 2023

r? @tiaanl @SimonSapin

I'm pretty sure we need the API change (requiring DeclarationListParser to implement QualifiedRuleParser), so I want to land it now (unpublished) to keep working on the Gecko bits.

The main question tho, is whether we want to unify these APIs a bit, which might be possible (something effectively like a trait RuleAndDeclarationParser which perhaps switches behavior a bit based on stylesheet position). But maybe for the future, once we have a better idea of what the nesting syntax requirements end up being?

@SimonSapin
Copy link
Member

This crate hasn’t exactly been the most stable in terms of avoiding breaking changes to public APIs, so I think another one is fine.

I’m not planning to do more maintenance work (beyond my recent PR) and I don’t have a strong opinion for this API, so I’ll leave it to y’all to decide.

@emilio
Copy link
Member Author

emilio commented Apr 29, 2023

@bors-servo r=tiaanl

@bors-servo
Copy link
Contributor

📌 Commit 2546cfa has been approved by tiaanl

@bors-servo
Copy link
Contributor

⌛ Testing commit 2546cfa with merge 3e1bd05...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: tiaanl
Pushing 3e1bd05 to master...

@bors-servo bors-servo merged commit 3e1bd05 into master Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants