Skip to content

[css-nesting] Fix body parsing recovery when nesting is not enabled. #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2023

Conversation

emilio
Copy link
Member

@emilio emilio commented May 16, 2023

Without the new nesting proposal, a stray semicolon in a media rule eats the next rule.

Without the new nesting proposal, a stray semicolon in a media rule eats
the next rule.
@emilio
Copy link
Member Author

emilio commented May 16, 2023

@bors-servo r+

  • Trivial fixup.

@bors-servo
Copy link
Contributor

📌 Commit dd6bb20 has been approved by emilio

@bors-servo
Copy link
Contributor

⌛ Testing commit dd6bb20 with merge 6ce91af...

@emilio
Copy link
Member Author

emilio commented May 16, 2023

Maybe we should switch the setup to instead of parse_qualified and parse_declarations we have something like { DeclarationsOnly, QualifiedOnly, DeclarationsAndQualified }...

@bors-servo
Copy link
Contributor

☀️ Test successful - checks-github
Approved by: emilio
Pushing 6ce91af to master...

@bors-servo bors-servo merged commit 6ce91af into master May 16, 2023
@emilio
Copy link
Member Author

emilio commented May 16, 2023

I'll experiment a bit more with such a setup once I get nesting working... Maybe it's simpler.

@emilio emilio deleted the nesting branch May 16, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants