Make the serialize_alpha function public. #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
May 19, 2023
src/color.rs
Outdated
| /// <https://drafts.csswg.org/css-color-4/#serializing-alpha-values> | ||
| #[inline] | ||
| fn serialize_alpha( | ||
| pub fn serialize_alpha( |
There was a problem hiding this comment.
Let's call this serialize_color_alpha or something then, since there's a other alpha values like opacity that are just a plain number / percent.
|
@bors-servo delegate+ |
|
✌️ @tiaanl can now approve this pull request |
|
@bors-servo r+ |
|
📌 Commit d5230b9 has been approved by |
|
☀️ Test successful - checks-github |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function is very handy in other places and is worth making public. Right now it will be used to generate specified value colors in Gecko.