cow-rc-str: Use ptr::NonNull. #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes UB caught by miri.
Closed
glandium
reviewed
Jun 6, 2023
|
LGTM. |
|
@bors-servo r=glandium |
|
📌 Commit 6cd4285 has been approved by |
|
☀️ Test successful - checks-github |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 10, 2023
…glandium,dlrobertson This prevents the compiler from misoptimizing this code due to undefined behavior. Upstream PR: servo/rust-cssparser#345 Differential Revision: https://phabricator.services.mozilla.com/D179921
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 12, 2023
…glandium,dlrobertson, a=dmeehan This prevents the compiler from misoptimizing this code due to undefined behavior. Upstream PR: servo/rust-cssparser#345 Differential Revision: https://phabricator.services.mozilla.com/D179921
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jun 16, 2023
…glandium,dlrobertson This prevents the compiler from misoptimizing this code due to undefined behavior. Upstream PR: servo/rust-cssparser#345 Differential Revision: https://phabricator.services.mozilla.com/D179921 UltraBlame original commit: 951284fe622cc3d375cade886ff33a9cb8f275fa
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jun 16, 2023
…glandium,dlrobertson This prevents the compiler from misoptimizing this code due to undefined behavior. Upstream PR: servo/rust-cssparser#345 Differential Revision: https://phabricator.services.mozilla.com/D179921 UltraBlame original commit: 951284fe622cc3d375cade886ff33a9cb8f275fa
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jun 16, 2023
…glandium,dlrobertson This prevents the compiler from misoptimizing this code due to undefined behavior. Upstream PR: servo/rust-cssparser#345 Differential Revision: https://phabricator.services.mozilla.com/D179921 UltraBlame original commit: 951284fe622cc3d375cade886ff33a9cb8f275fa
surapunoyousei
pushed a commit
to Floorp-Projects/Floorp
that referenced
this pull request
Jun 16, 2023
…glandium,dlrobertson, a=dmeehan This prevents the compiler from misoptimizing this code due to undefined behavior. Upstream PR: servo/rust-cssparser#345 Differential Revision: https://phabricator.services.mozilla.com/D179921
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes UB caught by miri.