Rgba does not store Option as component #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilio
approved these changes
Jul 24, 2023
src/color.rs
Outdated
| @@ -82,44 +82,34 @@ fn normalize_hue(hue: f32) -> f32 { | |||
|
|
|||
| /// A color with red, green, blue, and alpha components, in a byte each. | |||
| #[derive(Clone, Copy, PartialEq, Debug)] | |||
| pub struct RGBA { | |||
| pub struct Rgba { | |||
There was a problem hiding this comment.
Maybe we should call this LegacyRgba or somesuch?
There was a problem hiding this comment.
👍 Makes more sense, fixing.
Legacy `rgb`/`rgba` syntax does not allow the "none" keyword and although the modern `rgb`/`rgba` syntax does support it, it is immediately converted to 0, because we never have to serialize back to "none" keywords for `rgb`/`rgba`. Also `RGBA` is now renamed to `Rgba` as per common rust naming conventions now that it is not used directly in Gecko any more.
29fab94 to
5c7dd21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legacy
rgb/rgbasyntax does not allow the "none" keyword and although the modernrgb/rgbasyntax does support it, it is immediately converted to 0, because we never have to serialize back to "none" keywords forrgb/rgba.Also
RGBAis now renamed toRgbaas per common rust naming conventions now that it is not used directly in Gecko any more.