Export parse_color_keyword for use in legacy HTML color parsing.
#65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think that if you make this PR’s parent commit be the one Servo currently uses, you will be able to use it as-is in Servo. And if you add the r+ with these two changes. |
8646e3c to
c63bf90
Compare
Member
|
This is so we don’t need a branch that we’d have to maintain as long as we want |
I could have gotten around the privacy restriction by synthesizing a fake CSS AST and parsing that, but that would have been less efficient.
c63bf90 to
3f98f13
Compare
pcwalton
added a commit
that referenced
this pull request
Dec 8, 2014
Export `parse_color_keyword` for use in legacy HTML color parsing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could have gotten around the privacy restriction by synthesizing a
fake CSS AST and parsing that, but that would have been less efficient.
This won't merge because it's incompatible with the enum changes; I'll have to create a separate branch once the review is done.
r? @SimonSapin