Modernize the ToCss trait and implement it on more things. #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: Cargo.toml src/color.rs src/serializer.rs
|
The branch starts from an older commit that compiles with Servo’s version of Rust. servo/servo#4455 updates to just before the merge commit. r? @jdm |
|
I read the end result, and it makes sense to me. Do we care about newlines or spaces between declarations or anything like that? |
Not really. I’ve implemented |
|
Ok, feel free to merge this whenever you'd like. |
|
I’ll do so when servo/servo#4455 is ready to be merged as well. |
SimonSapin
added a commit
that referenced
this pull request
Dec 29, 2014
Modernize the ToCss trait and implement it on more things.
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 29, 2014
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 29, 2014
bors-servo
pushed a commit
to servo/servo
that referenced
this pull request
Dec 29, 2014
jrmuizel
pushed a commit
to jrmuizel/gecko-cinnabar
that referenced
this pull request
Jun 12, 2017
…serialization (from servo:to_css); r=jdm See servo/rust-cssparser#67 and servo/servo#4440. r? @jdm Source-Repo: https://github.com/servo/servo Source-Revision: b3059ee85b71b067e4b9e337faef53ae4a96c66d
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 30, 2019
…serialization (from servo:to_css); r=jdm See servo/rust-cssparser#67 and servo/servo#4440. r? jdm Source-Repo: https://github.com/servo/servo Source-Revision: b3059ee85b71b067e4b9e337faef53ae4a96c66d UltraBlame original commit: 445d2613a14ce5e1b73ec572f59caa6683742838
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 1, 2019
…serialization (from servo:to_css); r=jdm See servo/rust-cssparser#67 and servo/servo#4440. r? jdm Source-Repo: https://github.com/servo/servo Source-Revision: b3059ee85b71b067e4b9e337faef53ae4a96c66d UltraBlame original commit: 445d2613a14ce5e1b73ec572f59caa6683742838
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 1, 2019
…serialization (from servo:to_css); r=jdm See servo/rust-cssparser#67 and servo/servo#4440. r? jdm Source-Repo: https://github.com/servo/servo Source-Revision: b3059ee85b71b067e4b9e337faef53ae4a96c66d UltraBlame original commit: 445d2613a14ce5e1b73ec572f59caa6683742838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now based on the
TextWritertrait: https://github.com/SimonSapin/rust-std-candidates#the-textwriter-traitIt should be used for CSS serialization instead of
Show.