fix: handle whitespace between variable and colon

[e-cloud]

the variable declaration in less is somehow similar to at rule in css, makes its detection more complicated.

fix #92 , similar PR as #100. But this might be more generic.

Please check one:

• New tests created for this change
• Tests updated for this change

This PR:

• Adds new API
• Extends existing API, backwards-compatible
• Introduces a breaking change
• Fixes a bug

---

[shellscape]

@e-cloud @davidyorr I'll let you all hash this out. I'm impartial to one solution over another, but don't want to get in the middle and ruffle any feathers. you guys choose which PR is more fitting, and I'll go with that one.

[davidyorr]

It doesnt matter to me, theyre almost the same solution anyway. This PR is probably a bit cleaner to read because it makes use of the globals file.

I did think of a few edge cases that would fail though. (in both PRs)

// @page with no whitespace
@page:left { }
// variable name starting with @page and extra whitespace
@pageWidth : 1080px;
// @page as a variable name without pseudo class and extra whitespace
@page : 1080px;

I came up with a fix for those cases but im not sure the best way to add on to this PR.

[e-cloud]

@davidyorr After a small altering, the second case is handled now.

The first will be also parsed as non-variable, but will not be parsed as atrule. That's a deeper problem inside postcss.

The third problem is unresolvable via simple approach. Those ambigious variables should seldom exist.

[e-cloud]

@shellscape @davidyorr any further reaction?

[shellscape]

I leave it to you two to reach a consensus. I'll merge whichever you both agree on.

[davidyorr]

the new pageSelectorPattern doesn't work, it'll fail to parse variables starting with "page" that also have extra whitespace before the colon, something like @pagea :"test";

i think you might've meant pageSelectorPattern = /^@page[\W]+/;

[e-cloud]

@davidyorr you're right, my mistake.

[alexander-akait]

/cc @e-cloud @davidyorr what is status, we need this fix for prettier, thanks!

[davidyorr]

@shellscape i think this PR should be good to merge

[e-cloud]

@shellscape could you have a look and perhaps make a new release?

[shellscape]

@e-cloud @davidyorr @evilebottnawi will this be a breaking change for users reliant upon the previous processing patterns before the fix is applied? Need to know for the release process.

[alexander-akait]

@shellscape it is bug fix, because by Less spec allor to using whitespace before :. People who use this bug can get breaking change.